Skip to content

yes, uucore::pipes: merge pipe_with_size to pipe and catch fcntl err#12285

Merged
sylvestre merged 1 commit into
uutils:mainfrom
oech3:pipe3
May 16, 2026
Merged

yes, uucore::pipes: merge pipe_with_size to pipe and catch fcntl err#12285
sylvestre merged 1 commit into
uutils:mainfrom
oech3:pipe3

Conversation

@oech3
Copy link
Copy Markdown
Contributor

@oech3 oech3 commented May 14, 2026

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 14, 2026

GNU testsuite comparison:

Skip an intermittent issue tests/cut/bounded-memory (fails in this run but passes in the 'main' branch)
Congrats! The gnu test tests/pr/bounded-memory is now passing!

@oech3 oech3 changed the title uucore::pipes: merge pipe_with_size to pipe and catch fcntl err yes, uucore::pipes: merge pipe_with_size to pipe and catch fcntl err May 14, 2026
@oech3 oech3 marked this pull request as ready for review May 14, 2026 08:50
Comment thread src/uucore/src/lib/features/pipes.rs
@sylvestre sylvestre merged commit e408b5a into uutils:main May 16, 2026
170 of 171 checks passed
@oech3 oech3 deleted the pipe3 branch May 17, 2026 00:25
@xtqqczze
Copy link
Copy Markdown
Contributor

Broke cargo check --workspace --all-targets on non-Linux...

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 17, 2026

It is specification of cargo.

@xtqqczze
Copy link
Copy Markdown
Contributor

#12343

@oech3 In future when refactoring multi-platform code, could you check compilation with a few targets, e.g.:

cargo check --workspace --all-targets --target aarch64-apple-darwin

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 17, 2026 via email

@oech3
Copy link
Copy Markdown
Contributor Author

oech3 commented May 17, 2026

Actually, we should just remove the code does not appear on production or test for binary itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

uucore::pipes: remove pipe and use pipe_with_size(MAX_ROOTLESS_PIPE_SIZE)

3 participants